xinrong-meng commented on code in PR #45073:
URL: https://github.com/apache/spark/pull/45073#discussion_r1488693924
##########
python/pyspark/sql/profiler.py:
##########
@@ -158,6 +159,70 @@ def _profile_results(self) -> "ProfileResults":
"""
...
+ def dump_perf_profiles(self, path: str, id: Optional[int] = None) -> None:
Review Comment:
Good point!
V1 has `sc.dump_profiles/show_profiles` for both perf and memory profiling.
V2 has `spark.dumpPerfProfiles` and `spark.dumpMemoryProfiles` for perf and
memory profiling separately.
It would be more consistent and user-friendly to introduce a uniform
interface for both like `spark.profile.dump/show`.
Let me create a ticket for now.
What's your thought on that @ueshin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
