William1104 commented on PR #45101: URL: https://github.com/apache/spark/pull/45101#issuecomment-1944292205
Hi @dongjoon-hyun Thank you for taking the time to review my pull request. I appreciate your feedback and would like to address the points you raised. Regarding the declaration of explicit dependencies, I believe it is a common practice to declare dependencies explicitly when a module contains a class that directly depends on a specific library. This practice ensures that the dependencies are clearly defined and helps mitigate potential issues that may arise in the future. While a library like 'commons-text' may currently have 'commons-lang3' as a transitive dependency, there is no guarantee that this relationship will remain unchanged in future releases. By explicitly declaring the dependency, we can avoid any unexpected missing dependencies that might occur when upgrading 'commons-text'. However, I understand that different projects may have different approaches to handling dependency issues. If it is the established practice within the Spark project to address dependency issues only when they block enhancements or pose critical problems, I am willing to follow that practice and close this pull request accordingly. Thank you again for your review, and I look forward to any further guidance you may provide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
