Re: [PR] [SPARK-47040][CONNECT][FOLLOWUP] Improve usability of the start-conect-server-script.sh [spark]

Thu, 15 Feb 2024 23:12:08 -0800 


dongjoon-hyun commented on code in PR #45117:
URL: https://github.com/apache/spark/pull/45117#discussion_r1492039371


##########
sbin/start-connect-server.sh:
##########
@@ -40,8 +40,9 @@ fi
 
 if [ "$1" == "--wait" ]; then
   shift
-  exec "${SPARK_HOME}"/bin/spark-submit --class $CLASS 1 --name "Spark Connect 
Server" "$@"
-else
-  exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name "Spark 
Connect server" "$@"
+  export SPARK_NO_DAEMONIZE=1
 fi
+  exec "${SPARK_HOME}"/sbin/spark-daemon.sh submit $CLASS 1 --name "Spark 
Connect server" "$@"

Review Comment:
   While checking once more, I realized that we have extra leading spaces in 
this line. Could you double-check the indentation?
   
   ![Screenshot 2024-02-15 at 23 10 
56](https://github.com/apache/spark/assets/9700541/538e7354-9b61-4f37-b04d-b88dbb0d7d1e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to