sahnib commented on code in PR #44961: URL: https://github.com/apache/spark/pull/44961#discussion_r1489800175
########## sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StateTypesEncoderUtils.scala: ########## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.sql.execution.streaming + +import org.apache.commons.lang3.SerializationUtils + +import org.apache.spark.sql.catalyst.InternalRow +import org.apache.spark.sql.catalyst.encoders.ExpressionEncoder +import org.apache.spark.sql.catalyst.expressions.{UnsafeProjection, UnsafeRow} +import org.apache.spark.sql.execution.streaming.state.StateStoreErrors +import org.apache.spark.sql.types.{BinaryType, StructType} + +/** + * Helper object providing APIs to encodes the grouping key, and user provided values + * to Spark [[UnsafeRow]]. + */ +object StateTypesEncoderUtils { + + private val KEY_ROW_SCHEMA: StructType = new StructType().add("key", BinaryType) + private val VALUE_ROW_SCHEMA: StructType = new StructType().add("value", BinaryType) + + // TODO: validate places that are trying to encode the key and check if we can eliminate/ + // add caching for some of these calls. + def encodeGroupingKey(stateName: String, keyExprEnc: ExpressionEncoder[Any]): UnsafeRow = { + val keyOption = ImplicitGroupingKeyTracker.getImplicitKeyOption + if (keyOption.isEmpty) { + throw StateStoreErrors.implicitKeyNotFound(stateName) + } + + val toRow = keyExprEnc.createSerializer() + val keyByteArr = toRow + .apply(keyOption.get).asInstanceOf[UnsafeRow].getBytes() + + val keyEncoder = UnsafeProjection.create(KEY_ROW_SCHEMA) Review Comment: We do not anticipate a different schema. Every key, value will be encoded to a byte Array. While working on refactoring key/value Encoder to move them to object level, I discovered that `UnsafeProjection` is not thread safe. Hence, we cannot use it across state variables. Also, the user might try to do something weird - and access state data concurrently inside `transformWithState`. I think we should create a projection per encoding. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
