grundprinzip commented on code in PR #45150: URL: https://github.com/apache/spark/pull/45150#discussion_r1494297234
########## python/pyspark/shell.py: ########## @@ -45,11 +45,29 @@ if parent_dir in sys.path: sys.path.remove(parent_dir) - if is_remote(): try: # Creates pyspark.sql.connect.SparkSession. spark = SparkSession.builder.getOrCreate() Review Comment: checking a spark conf requires an active SparkSession to connect to the other side for the RPC call. I'm not a huge fan of creating client side config flags on the server. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org