panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1494414935
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/TableCatalog.java:
##########
@@ -97,6 +102,26 @@ public interface TableCatalog extends CatalogPlugin {
*/
Identifier[] listTables(String[] namespace) throws NoSuchNamespaceException;
+ /**
+ * List the tables in a namespace from the catalog by pattern string.
+ * <p>
+ * If the catalog supports views, this must return identifiers for only
tables and not views.
+ *
+ * @param namespace a multi-part namespace
+ * @param pattern the filter pattern, only '*' and '|' are allowed as
wildcards, others will
+ * follow regular expression convention, case-insensitive
match and white spaces
+ * on both ends will be ignored
Review Comment:
I searched the document and the `only possible relationship` is this one:
https://spark.apache.org/docs/latest/sql-ref-syntax-qry-select-like.html#parameters
<img width="910" alt="image"
src="https://github.com/apache/spark/assets/15246973/357c77e8-ecdb-404e-b479-b7b7459fd06b";>
Perhaps we should explain it in detail here?
(PS: The first pr that introduces `StringUtils.filterPattern` is:
https://github.com/apache/spark/pull/12206)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
