dongjoon-hyun commented on code in PR #45181:
URL: https://github.com/apache/spark/pull/45181#discussion_r1496457259
##########
sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala:
##########
@@ -3878,7 +3878,7 @@ class Dataset[T] private[sql](
*/
def persist(newLevel: StorageLevel): this.type = {
sparkSession.sharedState.cacheManager.cacheQuery(this, None, newLevel)
- this
+ Dataset(sparkSession, this.queryExecution.logical).asInstanceOf[this.type]
Review Comment:
IIUC, Apache Spark's the `persist` data (underlying RDD) can be recomputed
always, doesn't it? It's only for the best-effort approach to reduce
re-computation. Do we guarantee the cached data's immutability?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
