WweiL commented on code in PR #45091:
URL: https://github.com/apache/spark/pull/45091#discussion_r1498959891


##########
connector/connect/common/src/main/protobuf/spark/connect/commands.proto:
##########
@@ -421,6 +424,32 @@ message StreamingQueryManagerCommandResult {
   }
 }
 
+// The protocol for client-side StreamingQueryListener.
+// This command will only be set when either the first listener is added to 
the client, or the last
+// listener is removed from the client.
+// The add_listener_bus_listener command will only be set true in the first 
case.
+// The remove_listener_bus_listener command will only be set true in the 
second case.
+message StreamingQueryListenerBusCommand {
+  oneof command {
+    bool add_listener_bus_listener = 1;
+    bool remove_listener_bus_listener = 2;
+  }
+}
+
+// The protocol for the returned events in the long-running response channel.
+// The event_type for QueryProgressEvent is 1;
+// for QueryTerminatedEvent is 2; for QueryIdleEvent is 3;
+// There is no QueryStartedEvent defined here,

Review Comment:
   that would be a bit out of the scope of this protocol pr? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to