dongjoon-hyun commented on code in PR #45075:
URL: https://github.com/apache/spark/pull/45075#discussion_r1499722837
##########
common/utils/src/main/scala/org/apache/spark/util/MavenUtils.scala:
##########
@@ -335,10 +335,12 @@ private[spark] object MavenUtils extends Logging {
/* Set ivy settings for location of cache, if option is supplied */
private def processIvyPathArg(ivySettings: IvySettings, ivyPath:
Option[String]): Unit = {
- ivyPath.filterNot(_.trim.isEmpty).foreach { alternateIvyDir =>
- ivySettings.setDefaultIvyUserDir(new File(alternateIvyDir))
- ivySettings.setDefaultCache(new File(alternateIvyDir, "cache"))
+ val alternateIvyDir = ivyPath.filterNot(_.trim.isEmpty).getOrElse {
+ // To protect old Ivy-based systems like old Spark from Apache Ivy
2.5.2's incompatibility.
+ System.getProperty("user.home") + File.separator + ".ivy2.5.2"
Review Comment:
Ya, we can do that. I also thought `.ivy2.5` first, but it was misleading
because Ivy 2.5.0 and 2.5.1 are incompatible with 2.5.2. I originally wanted to
say `2.5.2+` here, but I dropped `+`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
