mridulm commented on code in PR #45155:
URL: https://github.com/apache/spark/pull/45155#discussion_r1500035173
##########
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkExecuteStatementOperation.scala:
##########
@@ -116,7 +116,7 @@ private[hive] class SparkExecuteStatementOperation(
val offset = iter.getPosition
val rows = iter.take(maxRows).toList
Review Comment:
These are private methods, and we can simply require `toRowBasedSet` to take
a `IndexedSeq` instead of `Seq` as proposed by @pan3793, right ?
I would have actually preferred this - as it minimizes the change (though
the reformulation in this PR is ok as well)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
