WweiL commented on code in PR #45221:
URL: https://github.com/apache/spark/pull/45221#discussion_r1500072399
##########
connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/consumer/KafkaDataConsumer.scala:
##########
@@ -624,31 +627,48 @@ private[kafka010] class KafkaDataConsumer(
/**
* Return an addition message including useful message and instruction.
*/
- private def additionalMessage(
+ private def additionalWarningMessage(
topicPartition: TopicPartition,
- groupId: String,
- failOnDataLoss: Boolean): String = {
- if (failOnDataLoss) {
- s"(GroupId: $groupId, TopicPartition: $topicPartition). " +
- s"$INSTRUCTION_FOR_FAIL_ON_DATA_LOSS_TRUE"
- } else {
- s"(GroupId: $groupId, TopicPartition: $topicPartition). " +
- s"$INSTRUCTION_FOR_FAIL_ON_DATA_LOSS_FALSE"
- }
+ groupId: String): String = {
+ s"(GroupId: $groupId, TopicPartition: $topicPartition). " +
+ s"$INSTRUCTION_FOR_FAIL_ON_DATA_LOSS_FALSE"
}
/**
- * Throw an exception or log a warning as per `failOnDataLoss`.
+ * Throw an exception when Data loss is detected.
Review Comment:
nit: data loss
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
