MaxGekk commented on code in PR #45218:
URL: https://github.com/apache/spark/pull/45218#discussion_r1502950928


##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -469,6 +469,12 @@
     ],
     "sqlState" : "42704"
   },
+  "COLLATION_SUPPORT_NOT_ENABLED" : {

Review Comment:
   Shouldn't we add a sub-class of `UNSUPPORTED_FEATURE`?



##########
common/utils/src/main/resources/error/error-classes.json:
##########
@@ -469,6 +469,12 @@
     ],
     "sqlState" : "42704"
   },
+  "COLLATION_SUPPORT_NOT_ENABLED" : {
+    "message" : [
+      "Collation support is under development and not all features are 
supported. To enable existing features set `spark.sql.collation.enabled` to 
`true`."

Review Comment:
   Replace `spark.sql.collation.enabled` by <config>, see other items in the 
file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to