cloud-fan commented on code in PR #45270:
URL: https://github.com/apache/spark/pull/45270#discussion_r1503514811
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -250,6 +250,29 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
}
}
+ /**
+ * Recursively transforms the expressions of a tree, first to all of its
Review Comment:
I think we should highlight that the traversal order is bottom-up for both
logical plan treea and expression tree.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/AnalysisHelper.scala:
##########
@@ -250,6 +250,29 @@ trait AnalysisHelper extends QueryPlan[LogicalPlan] {
self: LogicalPlan =>
}
}
+ /**
+ * Recursively transforms the expressions of a tree, first to all of its
Review Comment:
I think we should highlight that the traversal order is bottom-up for both
logical plan tree and expression tree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
