anishshri-db commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1505126889
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StatefulProcessorHandleImpl.scala:
##########
@@ -121,6 +123,42 @@ class StatefulProcessorHandleImpl(
override def getQueryInfo(): QueryInfo = currQueryInfo
+ private def getTimerState[T](): TimerStateImpl[T] = {
+ new TimerStateImpl[T](store, timeoutMode, keyEncoder)
+ }
+
+ private val timerState = getTimerState[Boolean]()
+
+ override def registerTimer(expiryTimestampMs: Long): Unit = {
+ verify(timeoutMode == ProcessingTime || timeoutMode == EventTime,
+ s"Cannot register timers with incorrect TimeoutMode")
+ verify(currState == INITIALIZED || currState == DATA_PROCESSED,
+ s"Cannot register timers with " +
+ s"expiryTimestampMs=$expiryTimestampMs in current state=$currState")
+
+ if (timerState.exists(expiryTimestampMs)) {
+ logWarning(s"Timer already exists for
expiryTimestampMs=$expiryTimestampMs")
Review Comment:
I thought we decided not to do this ? So basically we allow for a timestamp
earlier than latest to be generated which would fire the timer right away in
the next invocation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
