pan3793 commented on code in PR #45266:
URL: https://github.com/apache/spark/pull/45266#discussion_r1505247285
##########
core/src/main/scala/org/apache/spark/Dependency.scala:
##########
@@ -206,6 +206,21 @@ class ShuffleDependency[K: ClassTag, V: ClassTag, C:
ClassTag](
finalizeTask = Option(task)
}
+ // Set the threshold to 1 billion which represents approximately 1GB of
memory
+ // allocated to map output statuses.
Review Comment:
I agree with your decision, and I'm OK with the user-oriented warning
message, my only concern is this comment, we should point out that the
calculation of the memory consumption threshold is based on the worst case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
