panbingkun commented on code in PR #43751:
URL: https://github.com/apache/spark/pull/43751#discussion_r1505518259
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/ShowFunctionsSuiteBase.scala:
##########
@@ -159,15 +160,18 @@ trait ShowFunctionsSuiteBase extends QueryTest with
DDLCommandTestUtils {
test("show functions matched to the '|' pattern") {
val testFuns = Seq("crc32i", "crc16j", "date1900", "Date1")
- withNamespaceAndFuns("ns", testFuns) { (ns, funs) =>
- assert(sql(s"SHOW USER FUNCTIONS IN $ns").isEmpty)
- funs.foreach(createFunction)
- QueryTest.checkAnswer(
- sql(s"SHOW USER FUNCTIONS IN $ns LIKE 'crc32i|date1900'"),
- Seq("crc32i", "date1900").map(testFun => Row(qualifiedFunName("ns",
testFun))))
- QueryTest.checkAnswer(
- sql(s"SHOW USER FUNCTIONS IN $ns LIKE 'crc32i|date*'"),
- Seq("crc32i", "date1900", "Date1").map(testFun =>
Row(qualifiedFunName("ns", testFun))))
+ withSQLConf(
Review Comment:
Considering that this UT is testing "|" and "|" is no longer supported in
the new mode, we have set the configuration
`spark.sql.legacy.useVerticalBarAndStarAsWildcardsInLikePattern` to true to
complete this test. In the future, we can consider removing this UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
