mihailom-db commented on code in PR #45285:
URL: https://github.com/apache/spark/pull/45285#discussion_r1505706359
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -32,6 +33,11 @@ import org.apache.spark.sql.types.StringType
class CollationSuite extends DatasourceV2SQLBase {
protected val v2Source = classOf[FakeV2ProviderWithCustomSchema].getName
+ protected override def beforeAll(): Unit = {
+ System.setProperty(IS_TESTING.key, "true")
Review Comment:
I have just debugged without `CollationSuite.beforeAll()` override. Order of
calling was `SharedSparkSession.beforeAll()` -> `SQLConf.COLLATION_ENABLED`
setting -> `SparkFunSuite.beforeAll()`. This is causing the proposed test to
write `true` even though it was not set for the actual purpose and that is
before SQLConf invocation, so that the desired config is set with the right
value. Could you check that compilation does the same for you? I am not sure
why the compilation proceeds in the following manner, but if needed I could
investigate more?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
