srowen commented on PR #44690: URL: https://github.com/apache/spark/pull/44690#issuecomment-1968965418
This is how your current change works though, by rounding down by (more than) 1 ulp. Yes, error accumulates, and yes you still end up with the 'wrong' total resource left (it is positive when should be 0) but in any practical case, it does not cause the wrong scheduling. As per other comments, no this should not go into 3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
