ueshin commented on code in PR #45319:
URL: https://github.com/apache/spark/pull/45319#discussion_r1506558129
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/python/UserDefinedPythonFunction.scala:
##########
@@ -207,14 +207,22 @@ class UserDefinedPythonTableFunctionAnalyzeRunner(
case NamedArgumentExpression(k, v) => (Some(k), v)
case _ => (None, expr)
}
+ // Write the 'value' field to provide the argument's value if it is a
foldable scalar\
+ // expression.
if (value.foldable) {
dataOut.writeBoolean(true)
Review Comment:
Can we reuse this? This `true` and the `false` at line 217 should be the
same as `value.foldable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
