amaliujia commented on code in PR #45316:
URL: https://github.com/apache/spark/pull/45316#discussion_r1506639369
##########
python/pyspark/sql/connect/types.py:
##########
@@ -139,7 +139,7 @@ def pyspark_types_to_proto_types(data_type: DataType) ->
pb2.DataType:
if isinstance(data_type, NullType):
ret.null.CopyFrom(pb2.DataType.NULL())
elif isinstance(data_type, StringType):
- ret.string.CopyFrom(pb2.DataType.String())
+ ret.string.collation_id = data_type.collationId
Review Comment:
Is this change tested? The added UT seems to test proto -> type conversion
but not vice verse?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
