jwang0306 commented on PR #45238: URL: https://github.com/apache/spark/pull/45238#issuecomment-1969964182
> These are ByteArray Input/Output Stream's - which are scoped to that specific method; I am not sure I see value in wrapping it. Thanks for the input, @mridulm. At the moment I don't have a strong technical justification for this. Despite the fact that exceptions may be thrown potentially leading to resources not being released in a timely manner, admittedly there's no underlying expensive resources that need to be closed within these streams. I was simply considering the closing of streams after use as a good practice. I'm open to any decision regarding this PR, whether it be to close or merge it. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
