yaooqinn commented on code in PR #45384:
URL: https://github.com/apache/spark/pull/45384#discussion_r1512817343
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/OracleIntegrationSuite.scala:
##########
@@ -284,35 +288,20 @@ class OracleIntegrationSuite extends
DockerJDBCIntegrationSuite with SharedSpark
if (defaultJVMTimeZone == shanghaiTimeZone) sofiaTimeZone else
shanghaiTimeZone
withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key ->
localSessionTimeZone.getID) {
- checkError(
- exception = intercept[SparkSQLException] {
- sqlContext.read.jdbc(jdbcUrl, "ts_with_timezone", new
Properties).collect()
- },
- errorClass = "UNRECOGNIZED_SQL_TYPE",
- parameters = Map("typeName" -> "TIMESTAMP WITH TIME ZONE", "jdbcType"
-> "-101"))
+ checkAnswer(
+ sqlContext.read.jdbc(jdbcUrl, "ts_with_timezone", new Properties),
+ rsOfTsWithTimezone)
}
}
test("Column TIMESTAMP with TIME ZONE(JVM timezone)") {
- def checkRow(row: Row, ts: String): Unit = {
- assert(row.getTimestamp(1).equals(Timestamp.valueOf(ts)))
- }
-
withSQLConf(SQLConf.SESSION_LOCAL_TIMEZONE.key ->
TimeZone.getDefault.getID) {
val dfRead = sqlContext.read.jdbc(jdbcUrl, "ts_with_timezone", new
Properties)
- withDefaultTimeZone(PST) {
Review Comment:
This is just a refactoring to share `checkAnswer` and `rsOfTsWithTimezone`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
