neilramaswamy commented on PR #44323: URL: https://github.com/apache/spark/pull/44323#issuecomment-1979667133
As I was looking through this code some more, I realized that `getStateWatermark`, which is used to produce the output watermark, also [has this same incorrect logic](https://github.com/apache/spark/blob/c417c757907e262f78af5a84b8358e253d0d0954/sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamingSymmetricHashJoinHelper.scala#L157) for generating the watermark. This makes me think that one time interval condition with multiple stateful operators is also broken, since we won't return _any_ watermark, preventing propagation. I'll have to confirm if this is true, and then open another ticket if so. But just wanted to make reviewers aware that I am aware of this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
