zhengruifeng commented on code in PR #45232:
URL: https://github.com/apache/spark/pull/45232#discussion_r1515448887
##########
dev/sparktestsupport/modules.py:
##########
@@ -554,6 +554,7 @@ def __hash__(self):
"pyspark.resource.profile",
# unittests
"pyspark.resource.tests.test_resources",
+ "pyspark.resource.tests.test_connect_resources",
Review Comment:
this test is for spark connect, I think we should move it to Module
`pyspark_connect`?
maybe we can move the test cases in it to
`pyspark.sql.tests.connect.test_resources`?
##########
dev/sparktestsupport/modules.py:
##########
@@ -554,6 +554,7 @@ def __hash__(self):
"pyspark.resource.profile",
# unittests
"pyspark.resource.tests.test_resources",
+ "pyspark.resource.tests.test_connect_resources",
Review Comment:
this test is for spark connect, I think we should move it to Module
`pyspark_connect`?
or maybe we can move the test cases in it to
`pyspark.sql.tests.connect.test_resources`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
