attilapiros commented on code in PR #45424: URL: https://github.com/apache/spark/pull/45424#discussion_r1516669562
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala: ########## @@ -104,13 +104,19 @@ class AttributeSet private (private val baseSet: mutable.LinkedHashSet[Attribute * in `other`. */ def --(other: Iterable[NamedExpression]): AttributeSet = { Review Comment: and then we can save here what in the `missingInput()` was saved in your previous commit (the calculation of the `inputSet`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org