anishshri-db commented on code in PR #45051:
URL: https://github.com/apache/spark/pull/45051#discussion_r1522187745
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -195,6 +327,115 @@ class TransformWithStateSuite extends
StateStoreMetricsTest
}
}
+ test("transformWithState - streaming with rocksdb and processing time timer
" +
+ "should succeed") {
+ withSQLConf(SQLConf.STATE_STORE_PROVIDER_CLASS.key ->
+ classOf[RocksDBStateStoreProvider].getName) {
+ val clock = new StreamManualClock
+
+ val inputData = MemoryStream[String]
+ val result = inputData.toDS()
+ .groupByKey(x => x)
+ .transformWithState(new
RunningCountStatefulProcessorWithProcTimeTimer(),
+ TimeoutMode.ProcessingTime(),
+ OutputMode.Update())
+
+ testStream(result, OutputMode.Update())(
+ StartStream(Trigger.ProcessingTime("1 second"), triggerClock = clock),
+ AddData(inputData, "a"),
+ AdvanceManualClock(1 * 1000),
+ CheckNewAnswer(("a", "1")),
+
+ AddData(inputData, "b"),
+ AdvanceManualClock(1 * 1000),
+ CheckNewAnswer(("b", "1")),
+
+ AddData(inputData, "b"),
+ AdvanceManualClock(10 * 1000),
+ CheckNewAnswer(("a", "-1"), ("b", "2")),
+
+ StopStream,
+ StartStream(Trigger.ProcessingTime("1 second"), triggerClock = clock),
+ AddData(inputData, "b"),
+ AddData(inputData, "c"),
+ AdvanceManualClock(1 * 1000),
+ CheckNewAnswer(("c", "1")),
+ AddData(inputData, "d"),
+ AdvanceManualClock(10 * 1000),
+ CheckNewAnswer(("c", "-1"), ("d", "1")),
+ StopStream
+ )
+ }
+ }
+
+ test("transformWithState - streaming with rocksdb and processing time timer
" +
+ "and add/remove timers should succeed") {
+ withSQLConf(SQLConf.STATE_STORE_PROVIDER_CLASS.key ->
+ classOf[RocksDBStateStoreProvider].getName) {
+ val clock = new StreamManualClock
+
+ val inputData = MemoryStream[String]
+ val result = inputData.toDS()
+ .groupByKey(x => x)
+ .transformWithState(
+ new RunningCountStatefulProcessorWithAddRemoveProcTimeTimer(),
+ TimeoutMode.ProcessingTime(),
+ OutputMode.Update())
+
+ testStream(result, OutputMode.Update())(
+ StartStream(Trigger.ProcessingTime("1 second"), triggerClock = clock),
+ AddData(inputData, "a"),
+ AdvanceManualClock(1 * 1000),
+ CheckNewAnswer(("a", "1")),
+
+ AddData(inputData, "a"),
+ AdvanceManualClock(2 * 1000),
+ CheckNewAnswer(("a", "2")),
+ StopStream,
+
+ StartStream(Trigger.ProcessingTime("1 second"), triggerClock = clock),
+ AddData(inputData, "d"),
+ AdvanceManualClock(10 * 1000),
+ CheckNewAnswer(("a", "-1"), ("d", "1")),
Review Comment:
Done
##########
sql/core/src/test/scala/org/apache/spark/sql/streaming/TransformWithStateSuite.scala:
##########
@@ -53,8 +57,134 @@ class RunningCountStatefulProcessor extends
StatefulProcessor[String, String, (S
Iterator((key, count.toString))
}
}
+}
+
+// Class to verify stateful processor usage with adding processing time timers
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
