mridulm commented on code in PR #45240:
URL: https://github.com/apache/spark/pull/45240#discussion_r1522422583
##########
core/src/main/scala/org/apache/spark/resource/ResourceProfile.scala:
##########
@@ -489,10 +489,11 @@ object ResourceProfile extends Logging {
private[spark] def calculateOverHeadMemory(
overHeadMemFromConf: Option[Long],
+ minimumOverHeadMemoryFromConf: Long,
executorMemoryMiB: Long,
overheadFactor: Double): Long = {
overHeadMemFromConf.getOrElse(math.max((overheadFactor *
executorMemoryMiB).toInt,
- ResourceProfile.MEMORY_OVERHEAD_MIN_MIB))
+ minimumOverHeadMemoryFromConf))
Review Comment:
Discuss:
Do we need `MEMORY_OVERHEAD_MIN_MIB` after this PR is merged ?
If no, remove that field ?
yarn client mode AM overhead can be specified in that file, does not need to
be in `ResourceProfile` ... ditto for suites.
Thoughts @tgravescs, @jpcorreia99 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
