cloud-fan commented on code in PR #45470:
URL: https://github.com/apache/spark/pull/45470#discussion_r1522614115
##########
sql/api/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseLexer.g4:
##########
@@ -510,8 +511,13 @@ BIGDECIMAL_LITERAL
| DECIMAL_DIGITS EXPONENT? 'BD' {isValidDecimal()}?
;
+// Generalize the identifier to give a sensible INVALID_IDENTIFIER error
message:
+// * Unicode letters rather than a-z and A-Z only
+// * URI paths for table references using paths
+// We then narrow down to ANSI rules in exitUnquotedIdentifier() in the parser.
IDENTIFIER
- : (LETTER | DIGIT | '_')+
+ : (UNICODE_LETTER | DIGIT | '_')+
+ | UNICODE_LETTER+ '://' (UNICODE_LETTER | DIGIT | '_' | '/' | '-' | '.' |
'?' | '=' | '&' | '#' | '%')+
Review Comment:
I think it's not recommended to write string constants in the lexer, they
should be defined as keywords.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
