szehon-ho commented on code in PR #45267:
URL: https://github.com/apache/spark/pull/45267#discussion_r1523707057
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -829,20 +846,59 @@ case class KeyGroupedShuffleSpec(
}
}
+ override def canCreatePartitioning: Boolean =
SQLConf.get.v2BucketingShuffleEnabled &&
+ // Only support partition expressions are AttributeReference for now
+ partitioning.expressions.forall(_.isInstanceOf[AttributeReference])
+
+ override def createPartitioning(clustering: Seq[Expression]): Partitioning =
{
+ KeyGroupedPartitioning(clustering, partitioning.numPartitions,
partitioning.partitionValues)
+ }
+
+ override def reducers(other: ShuffleSpec): Option[Seq[Option[Reducer[_]]]] =
{
+ other match {
+ case otherSpec: KeyGroupedShuffleSpec =>
+ val results =
partitioning.expressions.zip(otherSpec.partitioning.expressions).map {
+ case (e1: TransformExpression, e2: TransformExpression)
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
