cloud-fan commented on code in PR #45479:
URL: https://github.com/apache/spark/pull/45479#discussion_r1524526381
##########
common/unsafe/src/main/java/org/apache/spark/unsafe/types/VariantVal.java:
##########
@@ -107,4 +107,17 @@ public String toString() {
// NOTE: the encoding is not yet implemented, this is not the final
implementation.
return new String(value);
}
+
+ /**
+ * Compare two variants in bytes. The variant equality is more complex than
it, and we haven't
+ * supported it in the user surface yet. This method is only intended for
tests.
+ */
+ @Override
+ public boolean equals(Object other) {
Review Comment:
`equals` should be overriden with `hashCode` together.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
