stefankandic commented on code in PR #45501:
URL: https://github.com/apache/spark/pull/45501#discussion_r1526591195
##########
common/unsafe/src/test/scala/org/apache/spark/unsafe/types/CollationFactorySuite.scala:
##########
@@ -138,4 +139,17 @@ class CollationFactorySuite extends AnyFunSuite with
Matchers { // scalastyle:ig
assert(result == testCase.expectedResult)
})
}
+
+ test("test concurrently generating collation keys") {
+ // generating ICU sort keys is not thread-safe by default so this should
fail
+ // if we don't handle the concurrency properly on Collator level
Review Comment:
right now we just do it by [freezing the
collator](https://github.com/apache/spark/blob/master/common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java#L141C7-L141C41)
as described in https://github.com/apache/spark/pull/45436, but we would
probably have to reexamine this as current solution is not very performant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
