MaxGekk commented on PR #45466: URL: https://github.com/apache/spark/pull/45466#issuecomment-2000162848
I have checked the new test suite locally: ``` $ build/sbt "sql/test:testOnly *XmlFunctionsSuite" [info] XmlFunctionsSuite: 22:50:44.233 WARN org.apache.hadoop.util.NativeCodeLoader: Unable to load native-hadoop library for your platform... using builtin-java classes where applicable [info] - from_xml (5 seconds, 317 milliseconds) [info] - from_xml with option (timestampFormat) (382 milliseconds) [info] - from_xml with option (rowTag) (153 milliseconds) [info] - from_xml with option (dateFormat) (180 milliseconds) ... [info] All tests passed. ``` +1, LGTM. Merging to master. Thank you, @yhosny and @zhengruifeng for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
