ianmcook commented on code in PR #45481:
URL: https://github.com/apache/spark/pull/45481#discussion_r1527183210
##########
python/pyspark/sql/pandas/conversion.py:
##########
@@ -241,21 +241,81 @@ def toPandas(self) -> "PandasDataFrameLike":
else:
return pdf
- def _collect_as_arrow(self, split_batches: bool = False) ->
List["pa.RecordBatch"]:
Review Comment:
Ok, understood. I will make some changes here to reflect that.
P.S. The git diff here is confusing and makes it look like I am proposing a
rename and full reimplementation of `_collect_as_arrow` which I am not :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
