cloud-fan commented on code in PR #45383:
URL: https://github.com/apache/spark/pull/45383#discussion_r1530217520
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala:
##########
@@ -64,7 +65,7 @@ abstract class TypeCoercionBase {
* is larger than decimal, and yet decimal is more precise than double, but
in
* union we would cast the decimal into double.
*/
- def findWiderCommonType(types: Seq[DataType]): Option[DataType]
+ def findWiderCommonType(children: Seq[DataType]): Option[DataType]
Review Comment:
why do we rename the parameter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
