yruslan commented on code in PR #41843:
URL: https://github.com/apache/spark/pull/41843#discussion_r1530575246
##########
connector/docker-integration-tests/src/test/scala/org/apache/spark/sql/jdbc/PostgresIntegrationSuite.scala:
##########
@@ -432,4 +437,18 @@ class PostgresIntegrationSuite extends
DockerJDBCIntegrationSuite {
assert(row(0).getSeq[String](0) == Seq("1", "fds", "fdsa"))
assert(row(0).getString(1) == "fdasfasdf")
}
+
+ test("SPARK-44280: infinity timestamp test") {
+ val df = sqlContext.read.jdbc(jdbcUrl, "infinity_timestamp", new
Properties)
+ val row = df.collect()
+
+ assert(row.length == 2)
+ val infinity = row(0).getAs[Timestamp]("timestamp_column")
+ val negativeInfinity = row(1).getAs[Timestamp]("timestamp_column")
+ val minTimeStamp = LocalDateTime.of(1, 1, 1, 0, 0,
0).toEpochSecond(ZoneOffset.UTC)
+ val maxTimestamp = LocalDateTime.of(9999, 12, 31, 23, 59,
59).toEpochSecond(ZoneOffset.UTC)
+
+ assert(infinity.getTime == maxTimestamp)
+ assert(negativeInfinity.getTime == minTimeStamp)
Review Comment:
`ts.getTime()' returns epoch in milliseconds, and
`LocalDateTime.toEpochSecond()` returns values in seconds.
Shouldn't this be
```scala
val minTimeStamp = LocalDateTime.of(1, 1, 1, 0, 0,
0).toEpochSecond(ZoneOffset.UTC) * 1000
val maxTimestamp = LocalDateTime.of(9999, 12, 31, 23, 59,
59).toEpochSecond(ZoneOffset.UTC) * 1000
```
Otherwise, `convertJavaTimestampToTimestamp()` does not return infinites as
expected
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
