Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/6482#discussion_r31293664
--- Diff:
core/src/main/scala/org/apache/spark/storage/DiskBlockManager.scala ---
@@ -139,8 +139,8 @@ private[spark] class DiskBlockManager(blockManager:
BlockManager, conf: SparkCon
}
private def addShutdownHook(): AnyRef = {
- Utils.addShutdownHook { () =>
- logDebug("Shutdown hook called")
+ Utils.addShutdownHook(Utils.TEMP_DIR_SHUTDOWN_PRIORITY + 1) { () =>
--- End diff --
Minor: but should we just add another constant for this in the main file?
It might be good to have all the relevant constants there, since ultimately
this is a problem that requires reasoning about global ordering.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
