gerashegalov commented on code in PR #45441:
URL: https://github.com/apache/spark/pull/45441#discussion_r1532660388


##########
bin/spark-class:
##########
@@ -77,6 +77,10 @@ set +o posix
 CMD=()
 DELIM=$'\n'
 CMD_START_FLAG="false"
+
+temp_file=$(mktemp)

Review Comment:
   Is it possible to avoid creating a temp file? Maybe wrapping the rest of the 
file after L84 into another function say run_command, so we have something like 
`build_command "$@" | run_command` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to