yaooqinn commented on code in PR #45626:
URL: https://github.com/apache/spark/pull/45626#discussion_r1533274803
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/OracleDialect.scala:
##########
@@ -230,3 +224,11 @@ private case object OracleDialect extends JdbcDialect {
override def supportsOffset: Boolean = true
}
+
+private[jdbc] object OracleDialect {
Review Comment:
This is only a place for containing some const ints, which represent some
variants from Oracle JDBC extensions. Thus, `object` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
