itholic commented on code in PR #45629: URL: https://github.com/apache/spark/pull/45629#discussion_r1533658180
########## python/pyspark/pandas/tests/indexes/test_reset_index.py: ########## @@ -22,6 +22,7 @@ from pyspark import pandas as ps from pyspark.testing.pandasutils import PandasOnSparkTestCase from pyspark.testing.sqlutils import SQLTestUtils +from pyspark.testing.utils import assertDataFrameEqual Review Comment: It is not a very big deal, but I personally recommend to use `assert_frame_equal` instead of `assertDataFrameEqual` for comparing Pandas API on Spark objects because `assert_frame_equal` directly leverage the Pandas testing utils internally so it is more proper to compare the Pandas objects: ``` from pyspark.pandas.testing import assert_frame_equal ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
