stevomitric commented on code in PR #45639:
URL: https://github.com/apache/spark/pull/45639#discussion_r1534028973
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -888,6 +888,158 @@ case class MapFromEntries(child: Expression)
copy(child = newChild)
}
+case class MapSort(base: Expression, ascendingOrder: Expression)
Review Comment:
Doesn't the `BinaryExpression` require two expressions here? Do we demote
this to UnaryExpression?
EDIT: `Expression` for `ascendingOrder` in array sorting has been set as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
