davidm-db commented on PR #45622: URL: https://github.com/apache/spark/pull/45622#issuecomment-2014071433
@MaxGekk I have addressed your latest comments by adding <filterExpr>, <aggExpr> and <windowExpr> parameters to the error messages. This significantly complicates test methods though, but I have constructed Expression strings using classes derived from Expression without any hardcoding, so I think it should be fine. The only way I have found to make everything work nicely (having nice output for the user, as well as be able to compare outputs properly in tests) is to use `toPrettySql()` method to convert expression to SQL-like string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
