yaooqinn commented on code in PR #45655:
URL: https://github.com/apache/spark/pull/45655#discussion_r1534984811
##########
sql/core/src/main/scala/org/apache/spark/sql/jdbc/MySQLDialect.scala:
##########
@@ -210,6 +210,7 @@ private case class MySQLDialect() extends JdbcDialect with
SQLConfHelper {
case FloatType => Option(JdbcType("FLOAT", java.sql.Types.FLOAT))
case StringType => Option(JdbcType("LONGTEXT", java.sql.Types.LONGVARCHAR))
case ByteType => Option(JdbcType("TINYINT", java.sql.Types.TINYINT))
+ case TimestampNTZType => Option(JdbcType("DATETIME",
java.sql.Types.TIMESTAMP))
case _ => JdbcUtils.getCommonJDBCType(dt)
Review Comment:
Partially. The typeName plays an important role in timestamp mapping but
`JdbcUtils.getCommonJDBCType` only cares about java.sql.Types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
