dongjoon-hyun commented on code in PR #45654: URL: https://github.com/apache/spark/pull/45654#discussion_r1535004974
########## sql/core/benchmarks/MakeDateTimeBenchmark-jdk21-results.txt: ########## @@ -1,22 +1,22 @@ -OpenJDK 64-Bit Server VM 21.0.1+12-LTS on Linux 5.15.0-1053-azure +OpenJDK 64-Bit Server VM 21.0.2+13-LTS on Linux 6.5.0-1016-azure AMD EPYC 7763 64-Core Processor make_date(): Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative ------------------------------------------------------------------------------------------------------------------------ -prepare make_date() 2004 2018 13 49.9 20.0 1.0X -make_date(2019, 9, 16) 2694 2737 52 37.1 26.9 0.7X -make_date(*, *, *) 3881 3906 37 25.8 38.8 0.5X +prepare make_date() 1981 2010 32 50.5 19.8 1.0X +make_date(2019, 9, 16) 1833 1849 14 54.5 18.3 1.1X Review Comment: ~`make_date` seems to be improved.~ It seems to be a flaky result. Java 17 result shows the similar result. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
