cloud-fan commented on code in PR #45657: URL: https://github.com/apache/spark/pull/45657#discussion_r1535133053
########## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityGenerator.scala: ########## @@ -36,9 +36,9 @@ class UnivocityGenerator( writerSettings.setHeaders(schema.fieldNames: _*) private val gen = new CsvWriter(writer, writerSettings) - // A `ValueConverter` is responsible for converting a value of an `InternalRow` to `String`. + // A `ValueConverter` is responsible for converting a value of an `Any` to `String`. // When the value is null, this converter should not be called. - private type ValueConverter = (InternalRow, Int) => String Review Comment: I get that we want to recursively call the converter for array, then we can use `(SpecializedGetters, Int)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
