stefankandic commented on code in PR #45641:
URL: https://github.com/apache/spark/pull/45641#discussion_r1535342122
##########
sql/core/src/test/scala/org/apache/spark/sql/CollationSuite.scala:
##########
@@ -423,22 +427,49 @@ class CollationSuite extends DatasourceV2SQLBase with
AdaptiveSparkPlanHelper {
}
test("create table with collation") {
- val tableName = "parquet_dummy_tbl"
+ val tableName = "dummy_tbl"
val collationName = "UTF8_BINARY_LCASE"
val collationId = CollationFactory.collationNameToId(collationName)
- withTable(tableName) {
- sql(
+ allFileBasedDataSources.foreach { format =>
+ withTable(tableName) {
+ sql(
s"""
- |CREATE TABLE $tableName (c1 STRING COLLATE $collationName)
- |USING PARQUET
+ |CREATE TABLE $tableName (
+ | c1 STRING COLLATE $collationName
+ |)
+ |USING $format
|""".stripMargin)
- sql(s"INSERT INTO $tableName VALUES ('aaa')")
- sql(s"INSERT INTO $tableName VALUES ('AAA')")
+ sql(s"INSERT INTO $tableName VALUES ('aaa')")
+ sql(s"INSERT INTO $tableName VALUES ('AAA')")
- checkAnswer(sql(s"SELECT DISTINCT COLLATION(c1) FROM $tableName"),
Seq(Row(collationName)))
- assert(sql(s"select c1 FROM $tableName").schema.head.dataType ==
StringType(collationId))
+ checkAnswer(sql(s"SELECT DISTINCT COLLATION(c1) FROM $tableName"),
Seq(Row(collationName)))
+ assert(sql(s"select c1 FROM $tableName").schema.head.dataType ==
StringType(collationId))
+ }
+ }
+ }
+
+ test("write collated data to different data sources with dataframe api") {
+ val collationName = "UNICODE_CI"
+
+ allFileBasedDataSources.foreach { format =>
+ withTempPath { path =>
+ val df = sql(s"SELECT c COLLATE UNICODE_CI AS c FROM VALUES ('aaa') AS
data(c)")
Review Comment:
my bad - fixed it now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
