dbatomic commented on code in PR #45592:
URL: https://github.com/apache/spark/pull/45592#discussion_r1535362379
##########
common/unsafe/src/main/java/org/apache/spark/sql/catalyst/util/CollationFactory.java:
##########
@@ -68,23 +68,30 @@ public static class Collation {
* Binary collation implies that UTF8Strings are considered equal only if
they are
* byte for byte equal. All accent or case-insensitive collations are
considered non-binary.
*/
- public final boolean isBinaryCollation;
+ public final boolean supportsBinaryEquality;
+ /**
+ * Binary collation implies that UTF8Strings are compared on byte level.
+ * All accent or case-insensitive collations are considered non-binary.
+ */
+ public final boolean supportsBinaryOrdering;
public Collation(
String collationName,
Collator collator,
Comparator<UTF8String> comparator,
String version,
ToLongFunction<UTF8String> hashFunction,
- boolean isBinaryCollation) {
+ boolean supportsBinaryEquality,
Review Comment:
Thank you for doing this, it finally starts to look like a proper API :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
