sebastianhillig-db commented on code in PR #45635:
URL: https://github.com/apache/spark/pull/45635#discussion_r1535787105
##########
core/src/main/scala/org/apache/spark/api/python/PythonWorkerFactory.scala:
##########
@@ -95,10 +95,19 @@ private[spark] class PythonWorkerFactory(
def create(): (PythonWorker, Option[Long]) = {
if (useDaemon) {
self.synchronized {
- if (idleWorkers.nonEmpty) {
+ while (idleWorkers.nonEmpty) {
val worker = idleWorkers.dequeue()
- worker.selectionKey.interestOps(SelectionKey.OP_READ |
SelectionKey.OP_WRITE)
- return (worker, daemonWorkers.get(worker))
+ val workerHandle = daemonWorkers(worker)
+ try {
+ worker.selectionKey.interestOps(SelectionKey.OP_READ |
SelectionKey.OP_WRITE)
+ } catch {
+ case c: CancelledKeyException => /* pass */
+ }
+ if (workerHandle.isAlive() && worker.selectionKey.isValid()) {
Review Comment:
It seems that this isn't always the case, i.e. the workerHandle may already
see the process being dead and selectionKey update will happily pass. I also
check `isValid` for the off-chance, that we got cancelled after interestOps was
set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
