mihailom-db commented on code in PR #45693:
URL: https://github.com/apache/spark/pull/45693#discussion_r1537435955
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala:
##########
@@ -1994,17 +1995,23 @@ case class Slice(x: Expression, start: Expression,
length: Expression)
case class ArrayJoin(
array: Expression,
delimiter: Expression,
- nullReplacement: Option[Expression]) extends Expression with
ExpectsInputTypes {
+ nullReplacement: Option[Expression]) extends ImplicitCastInputTypes {
def this(array: Expression, delimiter: Expression) = this(array, delimiter,
None)
def this(array: Expression, delimiter: Expression, nullReplacement:
Expression) =
this(array, delimiter, Some(nullReplacement))
- override def inputTypes: Seq[AbstractDataType] = if
(nullReplacement.isDefined) {
- Seq(ArrayType(StringType), StringType, StringType)
- } else {
- Seq(ArrayType(StringType), StringType)
+ override def inputTypes: Seq[AbstractDataType] = {
+ val arrayType = array.dataType.asInstanceOf[ArrayType].elementType match {
+ case _: StringType => array.dataType
+ case _ => ArrayType(StringType)
+ }
+ if (nullReplacement.isDefined) {
+ Seq(arrayType, StringTypeAnyCollation, StringTypeAnyCollation)
+ } else {
+ Seq(arrayType, StringTypeAnyCollation)
+ }
Review Comment:
This looks better, but I am still concerned that we are setting inputTypes
according to inputs that we get. If I understand the logic correctly, it should
be independent. I would rather leave this as ArrayType only and then override
checkInputTypes to do this check you performed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
