stevomitric commented on code in PR #45549:
URL: https://github.com/apache/spark/pull/45549#discussion_r1537509363
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/NormalizeFloatingNumbers.scala:
##########
@@ -144,6 +142,14 @@ object NormalizeFloatingNumbers extends Rule[LogicalPlan] {
val function = normalize(lv)
KnownFloatingPointNormalized(ArrayTransform(expr,
LambdaFunction(function, Seq(lv))))
+ case _ if expr.dataType.isInstanceOf[MapType] =>
+ val MapType(kt, vt, containsNull) = expr.dataType
+ val keys = NamedLambdaVariable("arg", kt, containsNull)
+ val values = NamedLambdaVariable("arg", vt, containsNull)
+ val function = normalize(values)
Review Comment:
Do we need to normalize keys? Would a conflict arise for a map that looks
like this: `Map(0.0 -> 1, -0.0 -> 2)` as we don't support duplicate keys and
`-0.0` would be reduced to `0.0`. Aren't keys normalized on map creation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
