HyukjinKwon commented on code in PR #45694:
URL: https://github.com/apache/spark/pull/45694#discussion_r1538490960
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CollationTypeConstraints.scala:
##########
@@ -53,6 +53,7 @@ abstract class StringTypeCollated extends AbstractDataType {
* Use StringTypeBinary for expressions supporting only binary collation.
*/
case object StringTypeBinary extends StringTypeCollated {
+ // TODO: When this AbstractDataType is first used, think of a proper
simpleString name
Review Comment:
Mind filing a JIRA, and make this like:
```
// TODO(SPARK-XXXXX): When this AbstractDataType is first used, think of a
proper simpleString name
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
